Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-43193][SS] Remove workaround for HADOOP-12074 #40852

Closed
wants to merge 1 commit into from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Apr 19, 2023

What changes were proposed in this pull request?

SPARK-19718 introduced different code branches for pre-Hadoop 2.8(w/o HADOOP-12074) and Hadoop 2.8+(w/ HADOOP-12074)

  1. Check if the message of IOException starts with java.lang.InterruptedException. If so, treat it as InterruptedException. This is for pre-Hadoop 2.8.
  2. Treat InterruptedIOException as InterruptedException. This is for Hadoop 2.8+ and other places that may throw InterruptedIOException when the thread is interrupted.

This PR removes the (1) since Spark no longer supports Hadoop2 now.

Why are the changes needed?

Since SPARK-42452 removed support for Hadoop2, we can remove the workaround code for pre Hadoop 2.8 now.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

@pan3793
Copy link
Member Author

pan3793 commented Apr 19, 2023

@pan3793
Copy link
Member Author

pan3793 commented Apr 20, 2023

also cc @sunchao

@zsxwing
Copy link
Member

zsxwing commented Apr 20, 2023

@pan3793 thanks for cleaning up the code! What does partially mean in the PR description?

@pan3793
Copy link
Member Author

pan3793 commented Apr 20, 2023

@zsxwing I mean this PR removes the code added in SPARK-19718 for pre-Hadoop 2.8, reserves the code for Hadoop 2.8+

@zsxwing
Copy link
Member

zsxwing commented Apr 20, 2023

@pan3793 Could you update the PR description to be more accurate? Thanks!

@pan3793
Copy link
Member Author

pan3793 commented Apr 21, 2023

@zsxwing updated, please take a look again, thanks.

Copy link
Member

@zsxwing zsxwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants