[SPARK-43202][YARN] Replace reflection w/ direct calling for YARN Resource API #40860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sunchao |
|
also cc @tgravescs |
|
@pan3793 jira id should be SPARK-43202 |
pan3793
changed the title
fixed |
LuciferYang
reviewed
Apr 20, 2023
| // TODO (SPARK-31733) Make this test case pass with hadoop-3 | ||
| assume(!isYarnResourceTypesAvailable) | ||
| // TODO (SPARK-31733) Make this test case pass with hadoop-3 | ||
| ignore("specify a more specific type for the application") { |
There was a problem hiding this comment.
#40877 try to fix this
LuciferYang
approved these changes
Apr 20, 2023
mridulm
approved these changes
Apr 20, 2023
|
Merged to master, thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace reflection w/ direct calling for YARN Resource API, including
org.apache.hadoop.yarn.api.records.ResourceInformation,org.apache.hadoop.yarn.exceptions.ResourceNotFoundExceptionwhich were added in YARN-4081 (Hadoop 2.10.0/3.0.0)
Why are the changes needed?
Simplify code. Since SPARK-42452 removed support for Hadoop 2, we can call those API directly now.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.