[SQL][Minor] Added comments and examples to explain BooleanSimplification #4090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @liancheng @scwf |
|
Test build #25709 has started for PR 4090 at commit
|
|
LGTM |
| // 2. Find the common predict between lhsSet and rhsSet, i.e. common = (a) | ||
| // 3. Remove common predict from lhsSet and rhsSet, i.e. ldiff = (b), rdiff = (c) | ||
| // 4. Apply the formula, get the optimized predicate: common || (ldiff && rdiff) | ||
| val lhsSet = splitDisjunctivePredicates(left).toSet |
There was a problem hiding this comment.
@liancheng pointed out that there is a bug in this code.
There was a problem hiding this comment.
yes,get it, there is a bug for case (a && b) || (a && b && c)
There was a problem hiding this comment.
wait， the case is right， i will check this with liancheng
There was a problem hiding this comment.
Yeah, the original logic is right, sorry for the trouble :(
|
Test build #25709 has finished for PR 4090 at commit
|
|
Test PASSed. |
asfgit
pushed a commit
that referenced
this pull request
Jan 20, 2015
…cation This is a follow-up of #4090. The original deeply nested `reduceOption` code is hard to grasp. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/4091) <!-- Reviewable:end --> Author: Cheng Lian <lian@databricks.com> Closes #4091 from liancheng/refactor-boolean-simplification and squashes the following commits: cd8860b [Cheng Lian] Improves `compareConditions` to handle more subtle cases 1bf3258 [Cheng Lian] Avoids converting predicate sets to lists e833ca4 [Cheng Lian] Refactors deeply nested FP style code
bomeng
pushed a commit
to Huawei-Spark/spark
that referenced
this pull request
Jan 21, 2015
…cation This is a follow-up of apache#4090. The original deeply nested `reduceOption` code is hard to grasp. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/4091) <!-- Reviewable:end --> Author: Cheng Lian <lian@databricks.com> Closes apache#4091 from liancheng/refactor-boolean-simplification and squashes the following commits: cd8860b [Cheng Lian] Improves `compareConditions` to handle more subtle cases 1bf3258 [Cheng Lian] Avoids converting predicate sets to lists e833ca4 [Cheng Lian] Refactors deeply nested FP style code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.