Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-43266][SQL] Move MergeScalarSubqueries to spark-sql #40932

Conversation

peter-toth
Copy link
Contributor

@peter-toth peter-toth commented Apr 24, 2023

What changes were proposed in this pull request?

This PR moves MergeScalarSubqueries from spark-catalyst to sparl-sql

Why are the changes needed?

Make SPARK-40193 / #37630 easier.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs.

@github-actions github-actions bot added the SQL label Apr 24, 2023
@peter-toth peter-toth changed the title [SPARK-43266][SQL] Move MergeScalarSubqueries to spark-sql [SPARK-43266][SQL] Move MergeScalarSubqueries to sql Apr 24, 2023
@peter-toth peter-toth changed the title [SPARK-43266][SQL] Move MergeScalarSubqueries to sql [SPARK-43266][SQL] Move MergeScalarSubqueries to spark-sql Apr 24, 2023
@peter-toth
Copy link
Contributor Author

cc @cloud-fan

@peter-toth peter-toth force-pushed the SPARK-43266-move-mergescalarsubqueries-to-sql branch from d50e115 to 37236f8 Compare July 31, 2023 11:13
Copy link
Contributor

@beliefer beliefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This change makes review easier.

@peter-toth
Copy link
Contributor Author

peter-toth commented Aug 22, 2023

Thank you. This change makes review easier.

No, this PR is not required any more.
Since I've updated #37630 and removed the physical plan comparison there is not need to move the MergeScalarSubqueries rule to spark-sql any more.
I'm gonna close this PR and please check the latest version of #37630. As there is no rule move in the latest version, github is able shows the actual diff better.

@peter-toth peter-toth closed this Aug 22, 2023
@beliefer
Copy link
Contributor

@peter-toth Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants