[SPARK-43381][CONNECT] Make 'transformStatCov' lazy #41055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @HyukjinKwon |
HyukjinKwon
approved these changes
May 7, 2023
|
Merged to master. |
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
May 10, 2023
### What changes were proposed in this pull request? Make 'transformStatCov' lazy ### Why are the changes needed? Existing implementation eagerly compute the `cov`, and return a local relation. Even through currently `message StatCov` is only used in 'Dataset.stat.cov' which returns a double value, it still should be a bit beneficial if we make 'transformStatCov' lazy, since the creation of local relation is skipped. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? existing UT Closes apache#41055 from zhengruifeng/connect_lazy_cov. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make 'transformStatCov' lazy
Why are the changes needed?
Existing implementation eagerly compute the
cov, and return a local relation.Even through currently
message StatCovis only used in 'Dataset.stat.cov' which returns a double value, it still should be a bit beneficial if we make 'transformStatCov' lazy, since the creation of local relation is skipped.Does this PR introduce any user-facing change?
No
How was this patch tested?
existing UT