[SPARK-43302][SQL][FOLLOWUP] Code cleanup for PythonUDAF #41142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @HyukjinKwon |
HyukjinKwon
reviewed
May 14, 2023
python/pyspark/sql/udf.py
Outdated
| sc.profiler_collector.add_profiler(id, memory_profiler) | ||
| else: | ||
| judf = self._judf | ||
| jPythonUDF = judf.apply(_to_seq(sc, cols, _to_java_column)) | ||
| return Column(jPythonUDF) | ||
|
|
||
| def _get_UDF_id(self, jexpr: JavaObject) -> int: |
There was a problem hiding this comment.
I think should be lowercased
Suggested change
| def _get_UDF_id(self, jexpr: JavaObject) -> int: | |
| def _get_udf_id(self, jexpr: JavaObject) -> int: |
HyukjinKwon
approved these changes
May 14, 2023
cloud-fan
commented
May 15, 2023
yaooqinn
approved these changes
May 17, 2023
|
thanks, merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #40739 to do some code cleanup
PYTHON_UDAFas it's not used by any rule.PythonFuncExpression.evalTypefor convenience: catalyst rules (including third-party extensions) may want to get the eval type of a python function, no matter it's UDF or UDAF.PythonUDAF.resultIdinstead ofAggregateExpression.resultId, to be consistent withPythonUDFWhy are the changes needed?
code cleanup
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests