[SPARK-43512][SS][TESTS] Update StateStoreOperationsBenchmark to reflect updates to RocksDB usage as state store provider #41175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to RocksDB usage as state store provider
anishshri-db
changed the title
|
@HeartSaVioR @LuciferYang - pls take a look. Thx Runs now complete ~40-50 mins. |
LuciferYang
reviewed
May 16, 2023
HeartSaVioR
approved these changes
May 16, 2023
There was a problem hiding this comment.
+1 pending CI.
It even becomes a better comparison between in-memory and RocksDB. In memory does not defer the actual write here, whereas previously we defer the actual write in RocksDB, so it wasn't a strictly apple-to-apple comparison. This is closer to real apple-to-apple comparison.
The fact which won't be changed is that in-memory is way faster. That cannot be changed.
dongjoon-hyun
changed the title
|
Thank you, @anishshri-db , @LuciferYang , @HeartSaVioR . Merged to master for Apache Spark 3.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update StateStoreOperationsBenchmark to reflect updates to RocksDB usage as state store provider
Why are the changes needed?
Need the changes to unblock RocksDB JNI upgrade
Does this PR introduce any user-facing change?
No
How was this patch tested?
Ran it locally and using Github Actions. Run now takes ~40-50mins