New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-43527][PYTHON] Fix catalog.listCatalogs
in PySpark
#41186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this PR should be backported to branch-3.4 |
cc @HyukjinKwon |
HyukjinKwon
approved these changes
May 16, 2023
Merged to master and branch-3.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
May 16, 2023
### What changes were proposed in this pull request? Fix `catalog.listCatalogs` in PySpark ### Why are the changes needed? existing implementation outputs incorrect results ### Does this PR introduce _any_ user-facing change? yes before this PR: ``` In [1]: spark.catalog.listCatalogs() Out[1]: [CatalogMetadata(name=<py4j.java_gateway.JavaMember object at 0x1031f08b0>, description=<py4j.java_gateway.JavaMember object at 0x1049ac2e0>)] ``` after this PR: ``` In [1]: spark.catalog.listCatalogs() Out[1]: [CatalogMetadata(name='spark_catalog', description=None)] ``` ### How was this patch tested? added doctest Closes #41186 from zhengruifeng/py_list_catalog. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit a232083) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? Fix `catalog.listCatalogs` in PySpark ### Why are the changes needed? existing implementation outputs incorrect results ### Does this PR introduce _any_ user-facing change? yes before this PR: ``` In [1]: spark.catalog.listCatalogs() Out[1]: [CatalogMetadata(name=<py4j.java_gateway.JavaMember object at 0x1031f08b0>, description=<py4j.java_gateway.JavaMember object at 0x1049ac2e0>)] ``` after this PR: ``` In [1]: spark.catalog.listCatalogs() Out[1]: [CatalogMetadata(name='spark_catalog', description=None)] ``` ### How was this patch tested? added doctest Closes apache#41186 from zhengruifeng/py_list_catalog. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit a232083) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
GladwinLee
pushed a commit
to lyft/spark
that referenced
this pull request
Oct 10, 2023
### What changes were proposed in this pull request? Fix `catalog.listCatalogs` in PySpark ### Why are the changes needed? existing implementation outputs incorrect results ### Does this PR introduce _any_ user-facing change? yes before this PR: ``` In [1]: spark.catalog.listCatalogs() Out[1]: [CatalogMetadata(name=<py4j.java_gateway.JavaMember object at 0x1031f08b0>, description=<py4j.java_gateway.JavaMember object at 0x1049ac2e0>)] ``` after this PR: ``` In [1]: spark.catalog.listCatalogs() Out[1]: [CatalogMetadata(name='spark_catalog', description=None)] ``` ### How was this patch tested? added doctest Closes apache#41186 from zhengruifeng/py_list_catalog. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit a232083) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Oct 10, 2023
### What changes were proposed in this pull request? Fix `catalog.listCatalogs` in PySpark ### Why are the changes needed? existing implementation outputs incorrect results ### Does this PR introduce _any_ user-facing change? yes before this PR: ``` In [1]: spark.catalog.listCatalogs() Out[1]: [CatalogMetadata(name=<py4j.java_gateway.JavaMember object at 0x1031f08b0>, description=<py4j.java_gateway.JavaMember object at 0x1049ac2e0>)] ``` after this PR: ``` In [1]: spark.catalog.listCatalogs() Out[1]: [CatalogMetadata(name='spark_catalog', description=None)] ``` ### How was this patch tested? added doctest Closes apache#41186 from zhengruifeng/py_list_catalog. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit a232083) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix
catalog.listCatalogs
in PySparkWhy are the changes needed?
existing implementation outputs incorrect results
Does this PR introduce any user-facing change?
yes
before this PR:
after this PR:
How was this patch tested?
added doctest