Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-43739][BUILD] Upgrade commons-io to 2.12.0 #41271

Closed
wants to merge 5 commits into from
Closed

[SPARK-43739][BUILD] Upgrade commons-io to 2.12.0 #41271

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c7beeb
[SPARK-43739][BUILD] Upgrade 'commons-io' & 'commons-crypto' to newes…
panbingkun May 23, 2023
177c083
[SPARK-43739][BUILD] Upgrade commons-io to 2.12.0
panbingkun May 23, 2023
2e39540
[SPARK-43739][BUILD] Upgrade commons-io to 2.12.0
panbingkun May 23, 2023
fdd6f0d
[SPARK-43739][BUILD] Upgrade commons-io to 2.12.0
panbingkun May 24, 2023
f5f82af
[SPARK-43739][BUILD] Upgrade commons-io to 2.12.0
panbingkun May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1349,7 +1349,7 @@ abstract class AvroSuite
spark.read.format("avro").load("*/*/*/*/*/*/*/something.avro")
}

intercept[FileNotFoundException] {
intercept[IOException] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a breaking change because this is a kind of information loss.
Could you mention this to the PR description?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what is the background of this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge it until I have investigated it thoroughly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add PathUtils.touch(Path)

Copy link
Contributor

@LuciferYang LuciferYang May 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
intercept[IOException] {
intercept[java.nio.file.NoSuchFileException] {

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

withTempPath { dir =>
FileUtils.touch(new File(dir, "test"))
withSQLConf(AvroFileFormat.IgnoreFilesWithoutExtensionProperty -> "true") {
Expand All @@ -1358,7 +1358,7 @@ abstract class AvroSuite
}
}

intercept[FileNotFoundException] {
intercept[IOException] {
withTempPath { dir =>
FileUtils.touch(new File(dir, "test"))

Expand Down
2 changes: 1 addition & 1 deletion dev/deps/spark-deps-hadoop-3-hive-2.3
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ commons-compiler/3.1.9//commons-compiler-3.1.9.jar
commons-compress/1.23.0//commons-compress-1.23.0.jar
commons-crypto/1.1.0//commons-crypto-1.1.0.jar
commons-dbcp/1.4//commons-dbcp-1.4.jar
commons-io/2.11.0//commons-io-2.11.0.jar
commons-io/2.12.0//commons-io-2.12.0.jar
commons-lang/2.6//commons-lang-2.6.jar
commons-lang3/3.12.0//commons-lang3-3.12.0.jar
commons-logging/1.1.3//commons-logging-1.1.3.jar
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@
<netlib.ludovic.dev.version>3.0.3</netlib.ludovic.dev.version>
<commons-codec.version>1.15</commons-codec.version>
<commons-compress.version>1.23.0</commons-compress.version>
<commons-io.version>2.11.0</commons-io.version>
<commons-io.version>2.12.0</commons-io.version>
<!-- org.apache.commons/commons-lang/-->
<commons-lang2.version>2.6</commons-lang2.version>
<!-- org.apache.commons/commons-lang3/-->
Expand Down