Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-43758][BUILD] Upgrade snappy-java to 1.1.10.0 #41285

Closed
wants to merge 2 commits into from

Conversation

sunchao
Copy link
Member

@sunchao sunchao commented May 23, 2023

What changes were proposed in this pull request?

This PR upgrades snappy-java version to 1.1.10.0 from 1.1.9.1.

Why are the changes needed?

The new snappy-java version fixes a potential issue for Graviton support when used with old GLIBC versions. See xerial/snappy-java#417.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing tests.

@github-actions github-actions bot added the BUILD label May 23, 2023
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending CI

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending CIs).
Thank you!

pom.xml Show resolved Hide resolved
@dongjoon-hyun
Copy link
Member

Thank you, @sunchao and all. Merged to master/3.4.

Most tests (except dependency test) passed in the first commit. And, second commit passed dependency test too.
Screenshot 2023-05-23 at 7 49 03 PM

dongjoon-hyun pushed a commit that referenced this pull request May 24, 2023
This PR upgrades `snappy-java` version to 1.1.10.0 from 1.1.9.1.

The new `snappy-java` version fixes a potential issue for Graviton support when used with old GLIBC versions. See xerial/snappy-java#417.

No

Existing tests.

Closes #41285 from sunchao/snappy-java.

Authored-by: Chao Sun <sunchao@apple.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 1e17c86)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun
Copy link
Member

Sorry folks. I missed that branch-3.4 has Hadoop 2 profile still. I made a follow-up for branch-3.4.

dongjoon-hyun added a commit that referenced this pull request May 24, 2023
### What changes were proposed in this pull request?

This Is a follow-up of #41285.

### Why are the changes needed?

When merging to branch-3.4, `hadoop-2` dependency manifest is missed.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes #41291 from dongjoon-hyun/SPARK-43758.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
czxm pushed a commit to czxm/spark that referenced this pull request Jun 12, 2023
### What changes were proposed in this pull request?

This PR upgrades `snappy-java` version to 1.1.10.0 from 1.1.9.1.

### Why are the changes needed?

The new `snappy-java` version fixes a potential issue for Graviton support when used with old GLIBC versions. See xerial/snappy-java#417.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Existing tests.

Closes apache#41285 from sunchao/snappy-java.

Authored-by: Chao Sun <sunchao@apple.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
This PR upgrades `snappy-java` version to 1.1.10.0 from 1.1.9.1.

The new `snappy-java` version fixes a potential issue for Graviton support when used with old GLIBC versions. See xerial/snappy-java#417.

No

Existing tests.

Closes apache#41285 from sunchao/snappy-java.

Authored-by: Chao Sun <sunchao@apple.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 1e17c86)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
### What changes were proposed in this pull request?

This Is a follow-up of apache#41285.

### Why are the changes needed?

When merging to branch-3.4, `hadoop-2` dependency manifest is missed.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes apache#41291 from dongjoon-hyun/SPARK-43758.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
GladwinLee pushed a commit to lyft/spark that referenced this pull request Oct 10, 2023
This PR upgrades `snappy-java` version to 1.1.10.0 from 1.1.9.1.

The new `snappy-java` version fixes a potential issue for Graviton support when used with old GLIBC versions. See xerial/snappy-java#417.

No

Existing tests.

Closes apache#41285 from sunchao/snappy-java.

Authored-by: Chao Sun <sunchao@apple.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 1e17c86)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
GladwinLee pushed a commit to lyft/spark that referenced this pull request Oct 10, 2023
### What changes were proposed in this pull request?

This Is a follow-up of apache#41285.

### Why are the changes needed?

When merging to branch-3.4, `hadoop-2` dependency manifest is missed.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes apache#41291 from dongjoon-hyun/SPARK-43758.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
catalinii pushed a commit to lyft/spark that referenced this pull request Oct 10, 2023
This PR upgrades `snappy-java` version to 1.1.10.0 from 1.1.9.1.

The new `snappy-java` version fixes a potential issue for Graviton support when used with old GLIBC versions. See xerial/snappy-java#417.

No

Existing tests.

Closes apache#41285 from sunchao/snappy-java.

Authored-by: Chao Sun <sunchao@apple.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 1e17c86)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
catalinii pushed a commit to lyft/spark that referenced this pull request Oct 10, 2023
### What changes were proposed in this pull request?

This Is a follow-up of apache#41285.

### Why are the changes needed?

When merging to branch-3.4, `hadoop-2` dependency manifest is missed.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes apache#41291 from dongjoon-hyun/SPARK-43758.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants