[SPARK-43773][CONNECT][PYTHON] Implement 'levenshtein(str1, str2[, threshold])' functions in python client #41296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' functions in python client
…' functions in python client
|
Waiting for #41293 |
python/pyspark/sql/functions.py
Outdated
| """Computes the Levenshtein distance of the two given strings. | ||
|
|
||
| .. versionadded:: 1.5.0 | ||
|
|
||
| .. versionchanged:: 3.4.0 | ||
| Supports Spark Connect. | ||
|
|
||
| .. versionchanged:: 3.5.0 | ||
| Supports Spark Connect. |
There was a problem hiding this comment.
I prefer another versionadded after parameter threshold, you can refer to
spark/python/pyspark/sql/pandas/map_ops.py
Lines 55 to 67 in ab4693d
Co-authored-by: Ruifeng Zheng <ruifengz@foxmail.com>
…' functions in python client
|
@panbingkun you would need |
Ok, let me try. Thanks! |
…' functions in python client
This is done. |
panbingkun
changed the title
|
merged to master |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
…r1, str2)' functions in python client ### What changes were proposed in this pull request? The pr aims to implement 'levenshtein(str1, str2[, threshold])' functions in python client ### Why are the changes needed? After Add a max distance argument to the levenshtein() function We have already implemented it on the scala side, so we need to align it on `pyspark`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - Manual testing python/run-tests --testnames 'python.pyspark.sql.tests.test_functions FunctionsTests.test_levenshtein_function' - Pass GA Closes apache#41296 from panbingkun/SPARK-43773. Lead-authored-by: panbingkun <pbk1982@gmail.com> Co-authored-by: panbingkun <84731559@qq.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to implement 'levenshtein(str1, str2[, threshold])' functions in python client
Why are the changes needed?
After Add a max distance argument to the levenshtein() function We have already implemented it on the scala side, so we need to align it on
pyspark.Does this PR introduce any user-facing change?
No.
How was this patch tested?
python/run-tests --testnames 'python.pyspark.sql.tests.test_functions FunctionsTests.test_levenshtein_function'