[SPARK-43676][SPARK-43677][SPARK-43678][SPARK-43679][PS] Fix DatetimeOps for Spark Connect
#41306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Ops for Spark Connect
zhengruifeng
approved these changes
May 29, 2023
|
merged to master |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
…eOps` for Spark Connect ### What changes were proposed in this pull request? This PR proposes to fix `DatetimeOps` test for pandas API on Spark with Spark Connect. This includes SPARK-43676, SPARK-43677, SPARK-43678, SPARK-43679 at once, because they are all related similar modifications in single file. ### Why are the changes needed? To support all features for pandas API on Spark with Spark Connect. ### Does this PR introduce _any_ user-facing change? Yes, `DatetimeOps.lt`, `DatetimeOps.le`, `DatetimeOps.ge`, `DatetimeOps.gt` are now working as expected on Spark Connect. ### How was this patch tested? Uncomment the UTs, and tested manually. Closes apache#41306 from itholic/SPARK-43676-9. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to fix
DatetimeOpstest for pandas API on Spark with Spark Connect.This includes SPARK-43676, SPARK-43677, SPARK-43678, SPARK-43679 at once, because they are all related similar modifications in single file.
Why are the changes needed?
To support all features for pandas API on Spark with Spark Connect.
Does this PR introduce any user-facing change?
Yes,
DatetimeOps.lt,DatetimeOps.le,DatetimeOps.ge,DatetimeOps.gtare now working as expected on Spark Connect.How was this patch tested?
Uncomment the UTs, and tested manually.