[SPARK-43516][ML][FOLLOW-UP] Drop vector type support in Distributed ML for spark connect #41420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
approved these changes
Jun 1, 2023
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
HyukjinKwon
approved these changes
Jun 2, 2023
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
…ML for spark connect ### What changes were proposed in this pull request? Drop vector type support in Distributed ML for spark connect. ### Why are the changes needed? Distributed ML is designed for supporting fitting / transforming over either spark dataframe or local pandas dataframe. Currently pandas dataframe does not have vector type similar to `spark.ml.linalg.Vector`, and Vector type does not have too much advantages except saving sparse features dataset. To make the interface consistent, we decided initial version does not support vector type. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? UT. Closes apache#41420 from WeichenXu123/mlv2-drop-vector-type-support. Authored-by: Weichen Xu <weichen.xu@databricks.com> Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Drop vector type support in Distributed ML for spark connect.
Why are the changes needed?
Distributed ML is designed for supporting fitting / transforming over either spark dataframe or local pandas dataframe.
Currently pandas dataframe does not have vector type similar to
spark.ml.linalg.Vector, and Vector type does not have too much advantages except saving sparse features dataset.To make the interface consistent, we decided initial version does not support vector type.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT.