[SPARK-43961][SQL][PYTHON][CONNECT] Add optional pattern for Catalog.listTables #41461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this makes sense to add the functionality to the Scala/Python APIs since it's already there in the SQL API. I also appreciate the cleanup of the duplicated code as well in this PR :) |
amaliujia
reviewed
Jun 7, 2023
| @@ -77,6 +77,8 @@ message ListDatabases { | |||
| message ListTables { | |||
| // (Optional) | |||
| optional string db_name = 1; | |||
| // (Optional) The pattern that the table name needs to match | |||
| optional string pattern = 2; | |||
There was a problem hiding this comment.
Do we need a test case for Spark Connect?
There was a problem hiding this comment.
I added test cases in CatalogSuite.
amaliujia
reviewed
Jun 7, 2023
| * @since 3.5.0 | ||
| */ | ||
| @throws[AnalysisException]("database does not exist") | ||
| override def listTables(dbName: String, pattern: String): Dataset[Table] = { |
There was a problem hiding this comment.
I think for the impl we can have one implementation of listTables.
def listTablesInternal(dbName: String, pattern: Optiona[String])
override def listTables(dbName: String) = listTablesInternal(dbName, None)
override def listTables(dbName: String, pattern: String) = listTablesInternal(dbName, Some(pattern))
amaliujia
reviewed
Jun 7, 2023
| @@ -403,6 +397,19 @@ class CatalogImpl(sparkSession: SparkSession) extends Catalog { | |||
| } | |||
| } | |||
|
|
|||
| private def wrapNamespace(dbName: String): Seq[String] = { | |||
There was a problem hiding this comment.
I feel like this method should be named resolveNamespace?
HyukjinKwon
approved these changes
Jun 7, 2023
|
thanks, merging to master! |
|
@cloud-fan @amaliujia @HyukjinKwon @holdenk Thank you! |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
…listTables ### What changes were proposed in this pull request? Currently, the syntax `SHOW TABLES LIKE pattern` supports an optional pattern, so as filtered out the expected tables. But the `Catalog.listTables` missing the function both in Catalog API and Connect Catalog API. In fact, the optional pattern is very useful. This PR also extracts the common `wrapNamespace` to clean up the duplicated code. ### Why are the changes needed? This PR want add the optional pattern for `Catalog.listTables`. ### Does this PR introduce _any_ user-facing change? 'No'. New feature. ### How was this patch tested? New test cases. Closes apache#41461 from beliefer/SPARK-43961. Authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, the syntax
SHOW TABLES LIKE patternsupports an optional pattern, so as filtered out the expected tables.But the
Catalog.listTablesmissing the function both in Catalog API and Connect Catalog API.In fact, the optional pattern is very useful.
This PR also extracts the common
wrapNamespaceto clean up the duplicated code.Why are the changes needed?
This PR want add the optional pattern for
Catalog.listTables.Does this PR introduce any user-facing change?
'No'.
New feature.
How was this patch tested?
New test cases.