[SPARK-44006][CONNECT][PYTHON] Support cache artifacts #41465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Jun 7, 2023
| @@ -623,6 +623,20 @@ def test_with_local_list(self): | |||
| ): | |||
| self.connect.createDataFrame(data, "col1 int, col2 int, col3 int") | |||
|
|
|||
| def test_streaming_local_relation(self): | |||
| import random | |||
| import string | |||
There was a problem hiding this comment.
we can just import them on the top
HyukjinKwon
reviewed
Jun 7, 2023
| @@ -271,6 +271,17 @@ def func(x): | |||
| self.spark.addArtifacts(f"{archive_path}.zip#my_files", archive=True) | |||
| self.assertEqual(self.spark.range(1).select(func("id")).first()[0], "hello world!") | |||
|
|
|||
| def test_cache_artifact(self): | |||
| import hashlib | |||
HyukjinKwon
approved these changes
Jun 7, 2023
MaxGekk
commented
Jun 7, 2023
| @@ -294,6 +295,15 @@ def func(x): | |||
| self.spark.addArtifacts(file_path, file=True) | |||
| self.assertEqual(self.spark.range(1).select(func("id")).first()[0], "Hello world!!") | |||
|
|
|||
| def test_cache_artifact(self): | |||
There was a problem hiding this comment.
@HyukjinKwon For some unknown reasons the test suit freezes after the test completes successfully.
I have added similar test for Scala client, please, review it: #41493
MaxGekk
changed the title
|
Merging to master. Thank you, @HyukjinKwon for review. |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
### What changes were proposed in this pull request? In the PR, I propose to extend Artifact API of the Python connect client by two new methods similarly to apache#40827: 1. `is_cached_artifact()` checks the cache of the given hash presents at the server side. 2. `cache_artifact()` caches a blob in memory at the server side. ### Why are the changes needed? To allow creating a dataframe from a large local collection. `spark.createDataFrame(...)` fails with the following error w/o the changes: ```python pyspark.errors.exceptions.connect.SparkConnectGrpcException: <_MultiThreadedRendezvous of RPC that terminated with: status = StatusCode.RESOURCE_EXHAUSTED details = "Sent message larger than max (629146388 vs. 134217728)" debug_error_string = "UNKNOWN:Error received from peer localhost:58218 {grpc_message:"Sent message larger than max (629146388 vs. 134217728)", grpc_status:8, created_time:"2023-06-05T18:35:50.912817+03:00"}" ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running new tests: ``` $ python/run-tests --parallelism=1 --testnames 'pyspark.sql.tests.connect.client.test_artifact ArtifactTests' ``` Closes apache#41465 from MaxGekk/streaming-createDataFrame-python-3. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to extend Artifact API of the Python connect client by two new methods similarly to #40827:
is_cached_artifact()checks the cache of the given hash presents at the server side.cache_artifact()caches a blob in memory at the server side.Why are the changes needed?
To allow creating a dataframe from a large local collection.
spark.createDataFrame(...)fails with the following error w/o the changes:Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running new tests: