Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-43977][CONNECT] Fix unexpected check result of dev/connect-jvm-client-mima-check #41473

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ object CheckConnectJvmClientCompatibility {
} catch {
case e: Throwable =>
println(e.getMessage)
resultWriter.write(s"ERROR: ${e.getMessage}")
resultWriter.write(s"ERROR: ${e.getMessage}\n")
Copy link
Member

@dongjoon-hyun dongjoon-hyun Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old code seems to exist since Apache Spark 3.4.0 but SPARK-43977 is filed for 3.5.0 only. Do we need to backport this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongjoon-hyun Thanks for your review. Good question. Due to Spark 3.4.x will not add new modules for mima check with connect module, this issue should not be triggered, so I think just fixing it in Spark 3.5.0 is enough now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it~

} finally {
if (resultWriter != null) {
resultWriter.close()
Expand Down
2 changes: 1 addition & 1 deletion dev/connect-jvm-client-mima-check
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ fi
rm -f .connect-mima-check-result

echo "Build required modules..."
build/sbt "sql/package;connect-client-jvm/assembly;connect-client-jvm/Test/package;avro/package;protobuf/package"
build/sbt "sql/package;connect-client-jvm/assembly;connect-client-jvm/Test/package;avro/package;protobuf/assembly"

CONNECT_TEST_CLASSPATH="$(build/sbt -DcopyDependencies=false "export connect-client-jvm/Test/fullClasspath" | grep jar | tail -n1)"
SQL_CLASSPATH="$(build/sbt -DcopyDependencies=false "export sql/fullClasspath" | grep jar | tail -n1)"
Expand Down