[SPARK-43663][CONNECT][PS] Enable SeriesParityTests.test_compare
#41567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Jun 13, 2023
HyukjinKwon
reviewed
Jun 13, 2023
HyukjinKwon
approved these changes
Jun 14, 2023
|
merged to master |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 19, 2023
### What changes were proposed in this pull request? This PR proposes to enable `SeriesParityTests.test_compare` for Spark Connect. ### Why are the changes needed? We should support the existing pandas-on-Spark APIs for Spark Connect as much as possible. ### Does this PR introduce _any_ user-facing change? Yes, `Series.compare` is now available on Spark Connect. ### How was this patch tested? Reusing the existing UT. Closes apache#41567 from itholic/SPARK-43633. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
|
good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to enable
SeriesParityTests.test_comparefor Spark Connect.Why are the changes needed?
We should support the existing pandas-on-Spark APIs for Spark Connect as much as possible.
Does this PR introduce any user-facing change?
Yes,
Series.compareis now available on Spark Connect.How was this patch tested?
Reusing the existing UT.