-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-44048][DOCS] Remove sql-migration-old.md #41583
Conversation
@@ -71,7 +71,7 @@ | |||
- text: PySpark Usage Guide for Pandas with Apache Arrow | |||
url: sql-pyspark-pandas-with-arrow.html | |||
- text: Migration Guide | |||
url: sql-migration-old.html | |||
url: sql-migration-guide.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you happen to know the history about -old.html
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @HyukjinKwon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was to keep the old URL so existing links are not broken. I think it's been pretty a while so I think we can just remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM, too.
Merged to master for Apache Spark 3.5.0. |
According to the affected version info of JIRA, I landed it to |
### What changes were proposed in this pull request? This PR removes sql-migration-old.md. ### Why are the changes needed? We can use sql-migration-guide.md directly without redirection: <img width="548" alt="image" src="https://github.com/apache/spark/assets/5399861/fdef4bea-7438-4570-b8ea-91a1a7fa86f5"> ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? manual test. Closes apache#41583 from wangyum/SPARK-44048. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
What changes were proposed in this pull request?
This PR removes sql-migration-old.md.
Why are the changes needed?
We can use sql-migration-guide.md directly without redirection:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
manual test.