Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-44048][DOCS] Remove sql-migration-old.md #41583

Closed
wants to merge 1 commit into from

Conversation

wangyum
Copy link
Member

@wangyum wangyum commented Jun 14, 2023

What changes were proposed in this pull request?

This PR removes sql-migration-old.md.

Why are the changes needed?

We can use sql-migration-guide.md directly without redirection:
image

Does this PR introduce any user-facing change?

No.

How was this patch tested?

manual test.

@github-actions github-actions bot added the DOCS label Jun 14, 2023
@@ -71,7 +71,7 @@
- text: PySpark Usage Guide for Pandas with Apache Arrow
url: sql-pyspark-pandas-with-arrow.html
- text: Migration Guide
url: sql-migration-old.html
url: sql-migration-guide.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you happen to know the history about -old.html?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was to keep the old URL so existing links are not broken. I think it's been pretty a while so I think we can just remove.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM, too.

@dongjoon-hyun
Copy link
Member

Merged to master for Apache Spark 3.5.0.

@dongjoon-hyun
Copy link
Member

According to the affected version info of JIRA, I landed it to master branch only.

@wangyum wangyum deleted the SPARK-44048 branch June 14, 2023 07:30
czxm pushed a commit to czxm/spark that referenced this pull request Jun 19, 2023
### What changes were proposed in this pull request?

This PR removes sql-migration-old.md.

### Why are the changes needed?

We can use sql-migration-guide.md directly without redirection:
<img width="548" alt="image" src="https://github.com/apache/spark/assets/5399861/fdef4bea-7438-4570-b8ea-91a1a7fa86f5">

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

manual test.

Closes apache#41583 from wangyum/SPARK-44048.

Authored-by: Yuming Wang <yumwang@ebay.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants