[SPARK-19335][SPARK-38200][SQL] Add upserts for writing to JDBC using MERGE INTO with temp table #41611
+679
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnricoMi
force-pushed
the
jdbc-upsert-merge-temp-table
branch
from
7a0e4d2
to
9cc6b39
Compare
EnricoMi
changed the title
EnricoMi
force-pushed
the
jdbc-upsert-merge-temp-table
branch
3 times, most recently
from
1ade6b4
to
76d0429
Compare
EnricoMi
force-pushed
the
jdbc-upsert-merge-temp-table
branch
from
76d0429
to
0439e5d
Compare
EnricoMi
changed the title
EnricoMi
force-pushed
the
jdbc-upsert-merge-temp-table
branch
from
95dc877
to
265dd1f
Compare
EnricoMi
force-pushed
the
jdbc-upsert-merge-temp-table
branch
from
265dd1f
to
2c3faec
Compare
EnricoMi
force-pushed
the
jdbc-upsert-merge-temp-table
branch
from
cdb889d
to
db2d78d
Compare
EnricoMi
force-pushed
the
jdbc-upsert-merge-temp-table
branch
from
db2d78d
to
464a19a
Compare
EnricoMi
force-pushed
the
jdbc-upsert-merge-temp-table
branch
2 times, most recently
from
7658bbc
to
80a2a9c
Compare
EnricoMi
force-pushed
the
jdbc-upsert-merge-temp-table
branch
from
80a2a9c
to
d064da1
Compare
EnricoMi
force-pushed
the
jdbc-upsert-merge-temp-table
branch
from
d064da1
to
5e69410
Compare
EnricoMi
force-pushed
the
jdbc-upsert-merge-temp-table
branch
3 times, most recently
from
38ce6b9
to
60e41ca
Compare
Derby does not support indices on temp tables: https://db.apache.org/derby/docs/10.2/ref/rrefdeclaretemptable.html
EnricoMi
force-pushed
the
jdbc-upsert-merge-temp-table
branch
from
10fd22b
to
e3ade6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implements upsert mode for
SaveMode.Appendof the MsSql, Postgres, Derby, H2 and oracle JDBC source.This uses
MERGE INTOin combination with a temporary table. A batch of rows is inserted into the temporary table (rather than the target table) and merged into the target table with oneMERGE INTOcommand per batch.See #41518 for an alternative for databases not supporting
MERGE INTOsyntax.Why are the changes needed?
The JDBC writer only supports either truncating the existing table or inserting. Duplicates, i.e. rows with identical values in the primary or unique index columns, cause an exception, permitting updating existing and inserting new rows.
Re-evaluating a partition due to executor loss will insert rows that have been inserted in an earlier attempt, which kills the entier Spark job.
Does this PR introduce any user-facing change?
This adds
upsertandupsertKeyColumnsoptions forSaveMode.Appendof the JDBC source.How was this patch tested?
Tests in
JdbcSuiteand integration suites.