[SPARK-43474] [SS] [CONNECT] Add SessionHolder to SparkConnectPlanner #41618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rangadi
commented
Jun 16, 2023
| @@ -79,7 +79,10 @@ final case class InvalidCommandInput( | |||
| private val cause: Throwable = null) | |||
| extends Exception(message, cause) | |||
|
|
|||
| class SparkConnectPlanner(val session: SparkSession) extends Logging { | |||
| class SparkConnectPlanner(val sessionHolder: SessionHolder) extends Logging { | |||
There was a problem hiding this comment.
This is the main change. The rest of the changes are consequence of API change.
@grundprinzip, @HyukjinKwon PTAL.
There was a problem hiding this comment.
I believe it needs some reviews @vicennial and/or @hvanhovell
grundprinzip
approved these changes
Jun 16, 2023
| @@ -51,11 +52,12 @@ trait SparkConnectPlanTest extends SharedSparkSession { | |||
| } | |||
|
|
|||
| def transform(rel: proto.Relation): logical.LogicalPlan = { | |||
| new SparkConnectPlanner(spark).transformRelation(rel) | |||
| new SparkConnectPlanner(SessionHolder.forTesting(spark)).transformRelation(rel) | |||
HyukjinKwon
approved these changes
Jun 16, 2023
|
Merging. |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 19, 2023
### What changes were proposed in this pull request? This adds SessionHolder rather than just SparkSession to `SparkConnectPlanner`. This is to allow access to session specific state at connect server level. Note that this is Spark-Connect specific session state, and is not stored with SparkSession. E.g. * Mapping from _dataframe reference id_ to actual dataframe in apache#41580 * File and archives stored with session in apache#41495 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - Existing unit tests. Closes apache#41618 from rangadi/session-holder. Authored-by: Raghu Angadi <raghu.angadi@databricks.com> Signed-off-by: Herman van Hovell <herman@databricks.com>
|
Thanks for the refactoring! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This adds SessionHolder rather than just SparkSession to
SparkConnectPlanner. This is to allow access to session specific state at connect server level. Note that this is Spark-Connect specific session state, and is not stored with SparkSession.E.g.
Does this PR introduce any user-facing change?
No.
How was this patch tested?