[SPARK-43929][SQL][PYTHON][CONNECT] Add date time functions to Scala, Python and Connect API - part 1 #41636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @zhengruifeng cc @HyukjinKwon |
… Python and Connect API - part 1
zhengruifeng
approved these changes
Jun 18, 2023
|
@beliefer please re-trigger the failed test |
|
thanks, merged to master |
|
@zhengruifeng Thank you! |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 19, 2023
… Python and Connect API - part 1 ### What changes were proposed in this pull request? This PR want add date time functions to Scala, Python and Connect API. These functions show below. - dateadd - date_diff - date_from_unix_date - day The origin plan also contains the two function `date_part` and `datepart`. You can see this PR exclude them, since we can't get the data type for unresolved expressions. Please refer https://github.com/apache/spark/blob/b97ce8b9a99c570fc57dec967e7e9db3d115c1db/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala#L2835 and https://github.com/apache/spark/blob/b97ce8b9a99c570fc57dec967e7e9db3d115c1db/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala#L2922 ### Why are the changes needed? Add date time functions to Scala, Python and Connect API. ### Does this PR introduce _any_ user-facing change? 'No'. New feature. ### How was this patch tested? New test cases. Closes apache#41636 from beliefer/SPARK-43929. Authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
zhengruifeng
pushed a commit
that referenced
this pull request
Jun 20, 2023
…t, date_part, datepart to Scala, Python and Connect API ### What changes were proposed in this pull request? This PR follows up #41636 and #41651 and add extract, date_part, datepart to Scala, Python and Connect API. ### Why are the changes needed? Add extract, date_part, datepart to Scala, Python and Connect API ### Does this PR introduce _any_ user-facing change? 'No'. New feature. ### How was this patch tested? New test cases. Closes #41667 from beliefer/datetime_functions_followup. Authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR want add date time functions to Scala, Python and Connect API. These functions show below.
The origin plan also contains the two function
date_partanddatepart. You can see this PR exclude them, since we can't get the data type for unresolved expressions. Please referspark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
Line 2835 in b97ce8b
spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
Line 2922 in b97ce8b
Why are the changes needed?
Add date time functions to Scala, Python and Connect API.
Does this PR introduce any user-facing change?
'No'.
New feature.
How was this patch tested?
New test cases.