[SPARK-44325][SQL] Use PartitionEvaluator API in SortMergeJoinExec #41884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinodkc
changed the title
vinodkc
changed the title
cloud-fan
reviewed
Jul 7, 2023
...core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinEvaluatorFactory.scala
Outdated
Show resolved
Hide resolved
vinodkc
force-pushed
the
br_refactorSortMergeJoinEvaluatorFactory
branch
from
406cb4b
to
2fad7f4
Compare
beliefer
reviewed
Jul 8, 2023
...core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinEvaluatorFactory.scala
Outdated
Show resolved
Hide resolved
vinodkc
force-pushed
the
br_refactorSortMergeJoinEvaluatorFactory
branch
3 times, most recently
from
9ca4b50
to
8717928
Compare
viirya
reviewed
Jul 9, 2023
...core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinEvaluatorFactory.scala
Outdated
Show resolved
Hide resolved
viirya
reviewed
Jul 9, 2023
vinodkc
force-pushed
the
br_refactorSortMergeJoinEvaluatorFactory
branch
from
8717928
to
80d960d
Compare
beliefer
reviewed
Jul 10, 2023
...core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinEvaluatorFactory.scala
Outdated
Show resolved
Hide resolved
vinodkc
force-pushed
the
br_refactorSortMergeJoinEvaluatorFactory
branch
from
80d960d
to
79937b5
Compare
cloud-fan
approved these changes
Jul 11, 2023
|
@viirya I think the benefit is that, we make it more clear what gets serialized and sent to the executor side. |
viirya
approved these changes
Jul 11, 2023
yaooqinn
approved these changes
Jul 11, 2023
|
LGTM+1 |
|
thanks @vinodkc and @cloud-fan @viirya @beliefer. merged to master |
vinodkc
commented
Jul 27, 2023
| } else { | ||
| left.execute().zipPartitions(right.execute()) { (leftIter, rightIter) => | ||
| val evaluator = evaluatorFactory.createEvaluator() | ||
| evaluator.eval(0, leftIter, rightIter) |
There was a problem hiding this comment.
zipPartitionsWithIndex method is currently absent, hence 0 index is passed to evaluator.eval(0, ...)
Once spark.sql.execution.useTaskEvaluator is set to true by default, this block will not be executed.
There was a problem hiding this comment.
can we use TaskContext.getPartitionId?
There was a problem hiding this comment.
nvm, it's different from index. Maybe we should just leave a note here about why we always use 0.
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
### What changes were proposed in this pull request? SQL operator `SortMergeJoinExec` updated to use the `PartitionEvaluator` API to do execution. ### Why are the changes needed? To avoid the use of lambda during distributed execution. Ref: SPARK-43061 for more details. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Updated 1 test case, once all the SQL operators are migrated, the flag `spark.sql.execution.useTaskEvaluator` will be enabled by default to avoid running the tests with and without this TaskEvaluator Closes apache#41884 from vinodkc/br_refactorSortMergeJoinEvaluatorFactory. Authored-by: Vinod KC <vinod.kc.in@gmail.com> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SQL operator
SortMergeJoinExecupdated to use thePartitionEvaluatorAPI to do execution.Why are the changes needed?
To avoid the use of lambda during distributed execution.
Ref: SPARK-43061 for more details.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Updated 1 test case, once all the SQL operators are migrated, the flag
spark.sql.execution.useTaskEvaluatorwill be enabled by default to avoid running the tests with and without this TaskEvaluator