New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-44349][R] Add math functions to SparkR #41914
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
force-pushed
the
math_r
branch
4 times, most recently
from
July 11, 2023 04:50
3688761
to
24dcf31
Compare
so remove |
HyukjinKwon
approved these changes
Jul 11, 2023
merged to master |
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
### What changes were proposed in this pull request? Add following math functions to `SparkR`: - ~~e~~ (discard together with `pi`, they are both math constants) - ~~pi~~ (conflict with R's built-in `pi` constant) - std - ln - negative - positive - ~~pow~~ (discard together with `power`) - ~~power~~ (conflict with R's built-in `power` function) - width_bucket ### Why are the changes needed? for parity ### Does this PR introduce _any_ user-facing change? yes ### How was this patch tested? updated UT Closes apache#41914 from zhengruifeng/math_r. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add following math functions to
SparkR
:e(discard together withpi
, they are both math constants)pi(conflict with R's built-inpi
constant)pow(discard together withpower
)power(conflict with R's built-inpower
function)Why are the changes needed?
for parity
Does this PR introduce any user-facing change?
yes
How was this patch tested?
updated UT