-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-44375][SQL] Use PartitionEvaluator API in DebugExec #41949
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @cloud-fan |
and @viirya |
viirya
reviewed
Jul 12, 2023
sql/core/src/main/scala/org/apache/spark/sql/execution/debug/DebugEvaluatorFactory.scala
Outdated
Show resolved
Hide resolved
viirya
reviewed
Jul 12, 2023
sql/core/src/main/scala/org/apache/spark/sql/execution/debug/DebugEvaluatorFactory.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Jul 13, 2023
viirya
approved these changes
Jul 13, 2023
cloud-fan
reviewed
Jul 14, 2023
sql/core/src/test/scala/org/apache/spark/sql/execution/debug/DebuggingSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Jul 17, 2023
sql/core/src/test/scala/org/apache/spark/sql/execution/debug/DebuggingSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Jul 19, 2023
thanks, merging to master! |
Thanks @cloud-fan @viirya @HyukjinKwon |
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
### What changes were proposed in this pull request? Use PartitionEvaluator API in DebugExec ### Why are the changes needed? use new api to avoid lambda-based distributed execution ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? add new test Closes apache#41949 from Hisoka-X/SPARK-44375_debug_exec. Authored-by: Jia Fan <fanjiaeminem@qq.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use PartitionEvaluator API in DebugExec
Why are the changes needed?
use new api to avoid lambda-based distributed execution
Does this PR introduce any user-facing change?
No
How was this patch tested?
add new test