[SPARK-43995][SPARK-43996][CONNECT] Add support for UDFRegistration to the Connect Scala Client #41953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicennial
changed the title
vicennial
changed the title
zhenlineo
approved these changes
Jul 12, 2023
vicennial
changed the title
HyukjinKwon
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Took a cursory look, and seems fine. cc @xinrong-meng too who worked about here.
|
Merged to master. |
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Jul 17, 2023
…o the Connect Scala Client ### What changes were proposed in this pull request? This PR adds support to register a scala UDF from the scala/jvm client. The following APIs are implemented in `UDFRegistration`: - `def register(name: String, udf: UserDefinedFunction): UserDefinedFunction` - `def register[RT: TypeTag, A1: TypeTag ...](name: String, func: (A1, ...) => RT): UserDefinedFunction` for 0 to 22 arguments. The following API is implemented in `functions`: - `def call_udf(udfName: String, cols: Column*): Column` Note: This PR is stacked on apache#41959. ### Why are the changes needed? To reach parity with classic Spark. ### Does this PR introduce _any_ user-facing change? Yes. spark.udf.register() is added as shown below: ```scala class A(x: Int) { def get = x * 100 } val myUdf = udf((x: Int) => new A(x).get) spark.udf.register("dummyUdf", myUdf) spark.sql("select dummyUdf(id) from range(5)").as[Long].collect() ``` The output: ```scala Array[Long] = Array(0L, 100L, 200L, 300L, 400L) ```` ### How was this patch tested? New tests in `ReplE2ESuite`. Closes apache#41953 from vicennial/SPARK-43995. Authored-by: vicennial <venkata.gudesa@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…o the Connect Scala Client ### What changes were proposed in this pull request? This PR adds support to register a scala UDF from the scala/jvm client. The following APIs are implemented in `UDFRegistration`: - `def register(name: String, udf: UserDefinedFunction): UserDefinedFunction` - `def register[RT: TypeTag, A1: TypeTag ...](name: String, func: (A1, ...) => RT): UserDefinedFunction` for 0 to 22 arguments. The following API is implemented in `functions`: - `def call_udf(udfName: String, cols: Column*): Column` Note: This PR is stacked on apache#41959. ### Why are the changes needed? To reach parity with classic Spark. ### Does this PR introduce _any_ user-facing change? Yes. spark.udf.register() is added as shown below: ```scala class A(x: Int) { def get = x * 100 } val myUdf = udf((x: Int) => new A(x).get) spark.udf.register("dummyUdf", myUdf) spark.sql("select dummyUdf(id) from range(5)").as[Long].collect() ``` The output: ```scala Array[Long] = Array(0L, 100L, 200L, 300L, 400L) ```` ### How was this patch tested? New tests in `ReplE2ESuite`. Closes apache#41953 from vicennial/SPARK-43995. Authored-by: vicennial <venkata.gudesa@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds support to register a scala UDF from the scala/jvm client.
The following APIs are implemented in
UDFRegistration:def register(name: String, udf: UserDefinedFunction): UserDefinedFunctiondef register[RT: TypeTag, A1: TypeTag ...](name: String, func: (A1, ...) => RT): UserDefinedFunctionfor 0 to 22 arguments.The following API is implemented in
functions:def call_udf(udfName: String, cols: Column*): ColumnNote: This PR is stacked on #41959.
Why are the changes needed?
To reach parity with classic Spark.
Does this PR introduce any user-facing change?
Yes. spark.udf.register() is added as shown below:
The output:
How was this patch tested?
New tests in
ReplE2ESuite.