[SPARK-44395][SQL] Update TVF arguments to require parentheses around identifier after TABLE keyword #41965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ueshin FYI |
ueshin
approved these changes
Jul 12, 2023
|
Thanks! merging to master. |
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
… identifier after TABLE keyword
### What changes were proposed in this pull request?
This PR updates the parsing of table function arguments to require parentheses around identifier after the TABLE keyword. Instead of `TABLE t`, the syntax should look like `TABLE(t)` instead as specified in the SQL standard.
* I kept the previous syntax without the parentheses as an optional case in the SQL grammar so that we can catch it in the `AstBuilder` and throw an informative error message telling the user to add parentheses and try the query again.
* I had to swap the order of parsing table function arguments, so the `table(identifier)` syntax does not accidentally parse as a scalar function call:
```
functionTableArgument
: functionTableReferenceArgument
| functionArgument
;
```
### Why are the changes needed?
This syntax is written down in the SQL standard. Per the standard, `TABLE identifier` should actually be passed as `TABLE(identifier)`.
### Does this PR introduce _any_ user-facing change?
Yes, SQL syntax changes slightly.
### How was this patch tested?
This PR adds and updates unit test coverage.
Closes apache#41965 from dtenedor/parentheses-table-clause.
Authored-by: Daniel Tenedorio <daniel.tenedorio@databricks.com>
Signed-off-by: Takuya UESHIN <ueshin@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates the parsing of table function arguments to require parentheses around identifier after the TABLE keyword. Instead of
TABLE t, the syntax should look likeTABLE(t)instead as specified in the SQL standard.I kept the previous syntax without the parentheses as an optional case in the SQL grammar so that we can catch it in the
AstBuilderand throw an informative error message telling the user to add parentheses and try the query again.I had to swap the order of parsing table function arguments, so the
table(identifier)syntax does not accidentally parse as a scalar function call:Why are the changes needed?
This syntax is written down in the SQL standard. Per the standard,
TABLE identifiershould actually be passed asTABLE(identifier).Does this PR introduce any user-facing change?
Yes, SQL syntax changes slightly.
How was this patch tested?
This PR adds and updates unit test coverage.