[SPARK-44264][ML][PYTHON] Support Distributed Training of Functions Using Deepspeed #42067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Jul 19, 2023
zhengruifeng
changed the title
|
@mathewjacob1002 please add the related labels in PR title |
mathewjacob1002
changed the title
zhengruifeng
changed the title
|
the |
|
@mathewjacob1002 the failure in |
|
Merged to master and branch-3.5. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jul 19, 2023
…sing Deepspeed Made the DeepspeedTorchDistributor run() method use the _run() function as the backbone. It allows the user to run distributed training of a function with deepspeed easily. This adds the ability for the user to pass in a function as the train_object when calling DeepspeedTorchDistributor.run(). The user must have all necessary imports within the function itself, and the function must be picklable. An example use case can be found in the python file linked in the JIRA ticket. Notebook/file linked in the JIRA ticket. Formal e2e tests will come in future PR. - [ ] Add more e2e tests for both running a regular pytorch file and running a function for training - [ ] Write more documentation Closes #42067 from mathewjacob1002/add_func_deepspeed. Authored-by: Mathew Jacob <mathew.jacob@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 392f8d8) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…sing Deepspeed ### What changes were proposed in this pull request? Made the DeepspeedTorchDistributor run() method use the _run() function as the backbone. ### Why are the changes needed? It allows the user to run distributed training of a function with deepspeed easily. ### Does this PR introduce _any_ user-facing change? This adds the ability for the user to pass in a function as the train_object when calling DeepspeedTorchDistributor.run(). The user must have all necessary imports within the function itself, and the function must be picklable. An example use case can be found in the python file linked in the JIRA ticket. ### How was this patch tested? Notebook/file linked in the JIRA ticket. Formal e2e tests will come in future PR. ### Next Steps/Timeline - [ ] Add more e2e tests for both running a regular pytorch file and running a function for training - [ ] Write more documentation Closes apache#42067 from mathewjacob1002/add_func_deepspeed. Authored-by: Mathew Jacob <mathew.jacob@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Made the DeepspeedTorchDistributor run() method use the _run() function as the backbone.
Why are the changes needed?
It allows the user to run distributed training of a function with deepspeed easily.
Does this PR introduce any user-facing change?
This adds the ability for the user to pass in a function as the train_object when calling DeepspeedTorchDistributor.run(). The user must have all necessary imports within the function itself, and the function must be picklable. An example use case can be found in the python file linked in the JIRA ticket.
How was this patch tested?
Notebook/file linked in the JIRA ticket. Formal e2e tests will come in future PR.
Next Steps/Timeline