[SPARK-44802][INFRA][FOLLOWUP] Fix to consider JIRA_ACCESS_TOKEN in precheck conditions #42502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recheck conditions
yaooqinn
approved these changes
Aug 16, 2023
yaooqinn
reviewed
Aug 16, 2023
|
Let's also update L611 with something like |
|
Thank you, @yaooqinn . |
Co-authored-by: Kent Yao <yao@apache.org>
|
I addressed the comments. Thank you again, @yaooqinn . |
|
Successfully merged PR #42511 and resolved the correlated JIRA issue w/these updates and w/o USER/PASSWORD. Thanks @dongjoon-hyun for the quick fix. Merged to master |
|
Thank you so much, @yaooqinn . :) |
valentinp17
pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
…recheck conditions ### What changes were proposed in this pull request? This is a follow-up of apache#42484 to fix the recheck conditions. ### Why are the changes needed? 1. Currently, the merge script fails at the last update stage because the rest of code requires JIRA_USERNAME **and** JIRA_PASSWORD still. ``` Would you like to pick afe1886 into another branch? (y/n): n JIRA_USERNAME and JIRA_PASSWORD not set Exiting without trying to close the associated JIRA. ``` 2. In addition, it shows improper warning at the initial stage. ``` $ dev/merge_spark_pr.py git rev-parse --abbrev-ref HEAD The env-vars JIRA_USERNAME and/or JIRA_PASSWORD are not set. Continue? (y/n): y Which pull request would you like to merge? (e.g. 34): ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual tests Closes apache#42502 from dongjoon-hyun/SPARK-44802. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…recheck conditions ### What changes were proposed in this pull request? This is a follow-up of apache#42484 to fix the recheck conditions. ### Why are the changes needed? 1. Currently, the merge script fails at the last update stage because the rest of code requires JIRA_USERNAME **and** JIRA_PASSWORD still. ``` Would you like to pick afe1886 into another branch? (y/n): n JIRA_USERNAME and JIRA_PASSWORD not set Exiting without trying to close the associated JIRA. ``` 2. In addition, it shows improper warning at the initial stage. ``` $ dev/merge_spark_pr.py git rev-parse --abbrev-ref HEAD The env-vars JIRA_USERNAME and/or JIRA_PASSWORD are not set. Continue? (y/n): y Which pull request would you like to merge? (e.g. 34): ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual tests Closes apache#42502 from dongjoon-hyun/SPARK-44802. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #42484 to fix the recheck conditions.
Why are the changes needed?
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual tests