Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-44939][R] Support Java 21 in SparkR SystemRequirements #42645

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Aug 24, 2023

What changes were proposed in this pull request?

This PR aims to update SystemRequirements to support Java 21 in SparkR.

Why are the changes needed?

To support Java 21 officially in SparkR. We've been running SparkR CI on master branch.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

On Java 21, do the following.

$ build/sbt test:package -Psparkr -Phive

$ R/install-dev.sh; R/run-tests.sh
...
Status: 2 NOTEs
See
  ‘/Users/dongjoon/APACHE/spark-merge/R/SparkR.Rcheck/00check.log’
for details.


+ popd
Tests passed.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the R label Aug 24, 2023
@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review August 24, 2023 05:28
Copy link
Member

@yaooqinn yaooqinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongjoon-hyun
Copy link
Member Author

Thank you, @yaooqinn !

@dongjoon-hyun
Copy link
Member Author

Thank you, @LuciferYang .

@dongjoon-hyun
Copy link
Member Author

I verified this manually with the procedure in the PR description. Merged to master for Apache Spark 4.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-44939 branch August 24, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants