[SPARK-45031][INFRA] Choose the right merge code path and merge hash for reopened PRs #42749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Sep 4, 2023
dongjoon-hyun
approved these changes
Sep 4, 2023
|
thank @HyukjinKwon and @dongjoon-hyun for merging to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When determining to cherry-pick a PR, we also check the PR is in the closed state; Otherwise, we assume it gets reverted and reopened, and we go normal merging.
When cherry-picking, we shall select the merge hash from the latest commit-close event instead of the oldest. This is a bug fix
Why are the changes needed?
Bugfix
Does this PR introduce any user-facing change?
no
How was this patch tested?
mutually
Was this patch authored or co-authored using generative AI tooling?
no