-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-45046][BUILD] Set shadeTestJar
of core
module to false
#42766
Conversation
Set ![]() All maven tests passed. |
cc @gengliangwang FYI |
@gengliangwang Do you still remember why changed |
I guess it was a mistake... |
BTW, there were multiple places setting
|
@gengliangwang The |
@LuciferYang Got it, thanks! |
Merged into master. Thanks @gengliangwang @HyukjinKwon |
@gengliangwang After further investigation, there are three modules that depend on |
What changes were proposed in this pull request?
This pr aims to set
shadeTestJar
ofcore
module tofalse
to skip shadespark-core**-tests.jar
process.Why are the changes needed?
Before SPARK-41244, the core module used the
maven-shade-plugin
configuration in theparent pom.xml
for shading, where theshadeTestJar
configuration item was set to the defaultfalse
in themaven-shade-plugin
inparent pom.xml
.In SPARK-41244 | SPARK-41244 #38779, the core module started using a separate
maven-shade-plugin
configuration and set theshadeTestJar
configuration item totrue
.And when
shadeTestJar
is true,maven-shade-plugin
always try to find(sometime is downloading) some non-existent jars:Under poor network conditions, the time for Maven compilation will increase.
On the other hand, setting shadeTestJar back to false has not resulted in any Maven test failures, so this pr reset
shadeTestJar
tofalse
.Does this PR introduce any user-facing change?
No
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No