[SPARK-5486] Added validate method to BlockMatrix #4279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #26344 has finished for PR 4279 at commit
|
|
Test build #26372 has finished for PR 4279 at commit
|
| @@ -172,6 +172,64 @@ class BlockMatrix( | |||
| assert(cols <= nCols, s"The number of columns $cols is more than claimed $nCols.") | |||
| } | |||
|
|
|||
| def validate: Unit = { | |||
There was a problem hiding this comment.
validate(), which is an action.
|
Test build #26390 has finished for PR 4279 at commit
|
| // Check if each MatrixBlock (except edges) has the dimensions rowsPerBlock x colsPerBlock | ||
| // The first tuple is the index and the second tuple is the dimensions of the MatrixBlock | ||
| blockInfo.foreach { case ((blockRowIndex, blockColIndex), (m, n)) => | ||
| if (m != rowsPerBlock || n != colsPerBlock) { |
There was a problem hiding this comment.
This is not correct. Checking m should be separate from checking n. m is valid if
(blockRowIndex < numRowBlocks - 1 && m == rowsPerBlock) || (blockRowIndex == numRowBlocks - 1 && m > 0 && m <= rowsPerBlock)
|
Test build #26411 has finished for PR 4279 at commit
|
|
LGTM. Merged into master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
validatemethod will allow users to debug theirBlockMatrix, if operations likeaddormultiplyreturn unexpected results. It checks the following properties in aBlockMatrix:BlockMatrixconsistent with what the user entered: (nRows,nCols)MatrixBlockconsistent with what the user entered: (rowsPerBlock,colsPerBlock)