[SPARK-43252][SQL] Replace the error class _LEGACY_ERROR_TEMP_2016 with an internal error
#42846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @MaxGekk |
MaxGekk
requested changes
Sep 11, 2023
| @@ -117,7 +117,7 @@ class CodeBlockSuite extends SparkFunSuite { | |||
|
|
|||
| test("Throws exception when interpolating unexpected object in code block") { | |||
| val obj = Tuple2(1, 1) | |||
| val e = intercept[IllegalArgumentException] { | |||
| val e = intercept[SparkException] { | |||
| code"$obj" | |||
| } | |||
| assert(e.getMessage().contains(s"Can not interpolate ${obj.getClass.getName}")) | |||
There was a problem hiding this comment.
As you are here, please, use checkError to check the error class and other parameters.
MaxGekk
approved these changes
Sep 11, 2023
|
Waiting for CI. |
|
@dengziming Could you resolve conflicts, please. |
dengziming
force-pushed
the
SPARK-43252
branch
from
4b750f5
to
c34158f
Compare
|
+1, LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace the legacy error class
_LEGACY_ERROR_TEMP_2016with an internal error as it is not triggered by the user space.Why are the changes needed?
As the error is not triggered by the user space, the legacy error class can be replaced by an internal error.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing test cases.
Was this patch authored or co-authored using generative AI tooling?
No.