[SPARK-45106][SQL] PercentileCont should check user supplied input
#42857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bersprockets
force-pushed
the
pc_checkinputtype_issue
branch
from
2e313a3
to
d4a2c73
Compare
|
cc @MaxGekk |
dongjoon-hyun
approved these changes
Sep 8, 2023
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 8, 2023
### What changes were proposed in this pull request? Change `PercentileCont` to explicitly check user-supplied input by calling `checkInputDataTypes` on the replacement. ### Why are the changes needed? `PercentileCont` does not currently check the user's input. If the runtime replacement (an instance of `Percentile`) rejects the user's input, the runtime replacement ends up unresolved. For example, this query throws an internal error rather than producing a useful error message: ``` select percentile_cont(b) WITHIN GROUP (ORDER BY a DESC) as x from (values (12, 0.25), (13, 0.25), (22, 0.25)) as (a, b); [INTERNAL_ERROR] Cannot resolve the runtime replaceable expression "percentile_cont(a, b)". The replacement is unresolved: "percentile(a, b, 1)". org.apache.spark.SparkException: [INTERNAL_ERROR] Cannot resolve the runtime replaceable expression "percentile_cont(a, b)". The replacement is unresolved: "percentile(a, b, 1)". at org.apache.spark.SparkException$.internalError(SparkException.scala:92) at org.apache.spark.SparkException$.internalError(SparkException.scala:96) at org.apache.spark.sql.catalyst.analysis.CheckAnalysis.$anonfun$checkAnalysis0$6(CheckAnalysis.scala:313) at org.apache.spark.sql.catalyst.analysis.CheckAnalysis.$anonfun$checkAnalysis0$6$adapted(CheckAnalysis.scala:277) ... ``` With this PR, the above query will produce the following error message: ``` [DATATYPE_MISMATCH.NON_FOLDABLE_INPUT] Cannot resolve "percentile_cont(a, b)" due to data type mismatch: the input percentage should be a foldable "DOUBLE" expression; however, got "b".; line 1 pos 7; ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #42857 from bersprockets/pc_checkinputtype_issue. Authored-by: Bruce Robbins <bersprockets@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 2b4387f) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
|
Merged to master/3.5. There is a conflict from branch-3.4. Could you make a PR for branch-3.4 and 3.3, please, @bersprockets ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change
PercentileContto explicitly check user-supplied input by callingcheckInputDataTypeson the replacement.Why are the changes needed?
PercentileContdoes not currently check the user's input. If the runtime replacement (an instance ofPercentile) rejects the user's input, the runtime replacement ends up unresolved.For example, this query throws an internal error rather than producing a useful error message:
With this PR, the above query will produce the following error message:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New tests.
Was this patch authored or co-authored using generative AI tooling?
No.