[SPARK-45118][PYTHON] Refactor converters for complex types to short cut when the element types don't need converters #42874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes don't need converters.
HyukjinKwon
approved these changes
Sep 11, 2023
zhengruifeng
approved these changes
Sep 12, 2023
| @@ -793,51 +851,94 @@ def correct_timestamp(pser: pd.Series) -> pd.Series: | |||
| def _converter(dt: DataType) -> Optional[Callable[[Any], Any]]: | |||
|
|
|||
| if isinstance(dt, ArrayType): | |||
| _element_conv = _converter(dt.elementType) or (lambda x: x) | |||
There was a problem hiding this comment.
Does the performance overhead come from this lambda function? Or does it come from this if statement:
def convert_xxx:
if value is None:
return None
There was a problem hiding this comment.
Yes, it's from the unnecessary lambda function call.
|
The test failure is from |
|
Thanks! merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactors converters for complex types to short cut when the element types don't need converters.
The following refactors are done in this PR:
Nones before calling the converterWhy are the changes needed?
When the element types in complex types don't need converters, we can provide a shortcut to avoid extra function calls.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added related tests and existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.