[SPARK-43628][SPARK-43629][CONNECT][PS][TESTS] Clear message for JVM dependent tests. #42955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itholic
commented
Sep 16, 2023
|
Could you re-trigger the failed pipelines? |
|
Merged to master for Apache Spark 4.0.0. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 25, 2023
…k ML dependent tests ### What changes were proposed in this pull request? Similar to #42955, this PR proposes to correct the message for Spark ML only tests from Spark Connect. ### Why are the changes needed? Among Spark ML dependent tests, there are some edge tests that can only be tested using Spark ML features. We need to be clearer about why these cannot be tested. ### Does this PR introduce _any_ user-facing change? No, it's test-only. ### How was this patch tested? Updated the existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #43051 from itholic/ml_dependent. Authored-by: Haejoon Lee <haejoon.lee@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to correct the message for JVM only tests from Spark Connect, and enable the tests when possible to workaround without JVM features.
Why are the changes needed?
Among JVM-dependent tests, there are tests that can be replaced without using JVM features, while there are some edge tests that can only be tested using JVM features. We need to be clearer about why these cannot be tested.
Does this PR introduce any user-facing change?
No. it's test-only
How was this patch tested?
Updated the existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.