Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-44366][BUILD] Upgrade antlr4 to 4.13.1 #43075

Closed
wants to merge 1 commit into from

Conversation

LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Sep 24, 2023

What changes were proposed in this pull request?

This pr is aims upgrade antlr4 from 4.9.3 to 4.13.1

Why are the changes needed?

After 4.10, antlr4 is using Java 11 for the source code and the compiled .class files for the ANTLR tool. There are some bug fix and Improvements after 4.9.3:

The full release notes as follows:

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GitHub Actions

Was this patch authored or co-authored using generative AI tooling?

No

@LuciferYang LuciferYang marked this pull request as draft September 24, 2023 16:58
@github-actions github-actions bot added the BUILD label Sep 24, 2023
@LuciferYang LuciferYang changed the title [SPARK-44366][BUILD] Test antlr4 4.13.1 [SPARK-44366][BUILD] Upgrade antlr4 to 4.13.1 Sep 24, 2023
@LuciferYang
Copy link
Contributor Author

Test first

@LuciferYang LuciferYang marked this pull request as ready for review September 25, 2023 06:15
@srowen
Copy link
Member

srowen commented Sep 26, 2023

Merged to master

@srowen srowen closed this in 13cd291 Sep 26, 2023
@LuciferYang
Copy link
Contributor Author

Thanks @srowen

@jimsimon-wk
Copy link

Any idea on when this might make it into a tagged release?

@srowen
Copy link
Member

srowen commented Oct 4, 2023

Looks like this would go out with 4.0 next year

@jimsimon-wk
Copy link

I noticed the Spark project uses maven-shade-plugin to relocate some dependencies. Any likelihood that we could provide a minor/patch version that provides shading for the antlr 4.9 dependency? There appears to be some conflicts with Hibernate 6.x.

@LuciferYang
Copy link
Contributor Author

I noticed the Spark project uses maven-shade-plugin to relocate some dependencies. Any likelihood that we could provide a minor/patch version that provides shading for the antlr 4.9 dependency? There appears to be some conflicts with Hibernate 6.x.

Spark 3.5 still uses antlr4 4.9.3.

@weikangchia
Copy link

Hi, I am also facing issues with conflicts with Hibernate 6.x and Spark 3.4.1. May I know if there is any solution or workaround I can use?

@LuciferYang
Copy link
Contributor Author

Hi, I am also facing issues with conflicts with Hibernate 6.x and Spark 3.4.1. May I know if there is any solution or workaround I can use?

This pr is for Spark 4.x version only and it's unrelated to Spark 3.4.1. Due to the Spark 3.x releases needing to support Java 8, it also can't be backported to Spark 3.4.1. If you have other issues to discuss, you can initiate a discussion via the dev mailing list or create a related jira (even your improved patch). Thanks :)

doruchiulan pushed a commit to BlueprintTechnologies/spark-lhm that referenced this pull request Feb 2, 2024
### What changes were proposed in this pull request?
This pr is aims upgrade `antlr4` from 4.9.3 to 4.13.1

### Why are the changes needed?
After 4.10, antlr4 is using Java 11 for the source code and the compiled .class files for the ANTLR tool. There are some bug fix and Improvements after 4.9.3:
- antlr/antlr4#3399
- antlr/antlr4#1105
- antlr/antlr4#2788
- antlr/antlr4#3957
- antlr/antlr4#4394

The full release notes as follows:

- https://github.com/antlr/antlr4/releases/tag/4.13.1
- https://github.com/antlr/antlr4/releases/tag/4.13.0
- https://github.com/antlr/antlr4/releases/tag/4.12.0
- https://github.com/antlr/antlr4/releases/tag/4.11.1
- https://github.com/antlr/antlr4/releases/tag/4.11.0
- https://github.com/antlr/antlr4/releases/tag/4.10.1
- https://github.com/antlr/antlr4/releases/tag/4.10

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Pass GitHub Actions

### Was this patch authored or co-authored using generative AI tooling?
No

Closes apache#43075 from LuciferYang/antlr4-4131.

Authored-by: yangjie01 <yangjie01@baidu.com>
Signed-off-by: Sean Owen <srowen@gmail.com>
(cherry picked from commit 13cd291)
dongjoon-hyun added a commit that referenced this pull request Feb 9, 2024
### What changes were proposed in this pull request?

This PR aims to remove an outdated `antlr4` comment in `pom.xml`.

### Why are the changes needed?

This was missed when SPARK-44366 upgraded `antlr4` from 4.9.3 to 4.13.1.

- #43075

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manual review.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #45076 from dongjoon-hyun/SPARK_ANTLR.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants