Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-45312][SQL][UI] Support toggle display/hide plan svg on execution page #43099

Closed
wants to merge 1 commit into from

Conversation

yaooqinn
Copy link
Member

What changes were proposed in this pull request?

This PR supports toggle display/hide plan svg on the execution page.

Why are the changes needed?

Improve UX for the execution page, especially for large plans

Does this PR introduce any user-facing change?

yes, UI changes

How was this patch tested?

tested locally

Screen.Recording.2023-09-25.at.17.12.28.mov

Was this patch authored or co-authored using generative AI tooling?

no

@yaooqinn
Copy link
Member Author

cc @sarutak @dongjoon-hyun @HyukjinKwon @cloud-fan thanks

@dongjoon-hyun
Copy link
Member

Nice Video Demo! :)

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@yaooqinn
Copy link
Member Author

Thank you @dongjoon-hyun

@dongjoon-hyun
Copy link
Member

Merged to master for Apache Spark 4.0.0.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Sep 26, 2023

Oh, could you mitigate the linter complain, @yaooqinn ? I missed that. The linter seems to be confused while the function togglePlanViz is used correctly.

/__w/spark/spark/sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/spark-sql-viz.js
  261:10  error  'togglePlanViz' is defined but never used  no-unused-vars

@yaooqinn
Copy link
Member Author

Sorry about the linter mistake. Could you make a followup for me if you have some time?I am on vacation:)

@Hisoka-X
Copy link
Member

I add a followup PR for this. #43124 @dongjoon-hyun @yaooqinn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants