Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-45317][SQL][CONNECT] Handle null filename in stack traces of exceptions #43103

Closed
wants to merge 1 commit into from

Conversation

heyihong
Copy link
Contributor

@heyihong heyihong commented Sep 25, 2023

What changes were proposed in this pull request?

  • Handle null filename in stack traces of exceptions
  • Change the filename field in protobuf to optional

Why are the changes needed?

  • In Java exceptions, filename is the only field that can be nullable and null filename may cause NullPointerException

Does this PR introduce any user-facing change?

No

How was this patch tested?

  • build/sbt "connect-client-jvm/testOnly *ClientE2ETestSuite"
  • build/sbt "connect-client-jvm/testOnly *ClientStreamingQuerySuite"

Was this patch authored or co-authored using generative AI tooling?

@heyihong heyihong changed the title [SPARK-45317] Handle null filename in stack traces of exceptions [SPARK-45317][SQL][CONNECT] Handle null filename in stack traces of exceptions Sep 25, 2023
@heyihong
Copy link
Contributor Author

@hvanhovell @juliuszsompolski Please take a look

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants