Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-45334][SQL] Remove misleading comment in parquetSchemaConverter #43119

Conversation

amoylan2
Copy link

What changes were proposed in this pull request?

Remove one line of comment, the detail info is described in JIRA https://issues.apache.org/jira/browse/SPARK-45334

Why are the changes needed?

The comment is outdated and misleading.

Does this PR introduce any user-facing change?

No

How was this patch tested?

No need

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the SQL label Sep 26, 2023
@amoylan2 amoylan2 force-pushed the remove_misleading_comment_in_parquetSchemaConverter branch from 0448192 to 29b0e3f Compare September 26, 2023 10:05
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build failure really can't be related. Merging to master

@srowen srowen closed this in 7e8aafd Sep 27, 2023
@amoylan2 amoylan2 deleted the remove_misleading_comment_in_parquetSchemaConverter branch September 27, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants