Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-5540] hide ALS.solveLeastSquares #4318

Closed
wants to merge 1 commit into from

Conversation

mengxr
Copy link
Contributor

@mengxr mengxr commented Feb 2, 2015

This method survived the code review and it has been there since v1.1.0. It exposes jblas types. Let's remove it from the public API. I think no one calls it directly.

@SparkQA
Copy link

SparkQA commented Feb 2, 2015

Test build #26557 has started for PR 4318 at commit 586ade6.

  • This patch merges cleanly.

@srowen
Copy link
Member

srowen commented Feb 3, 2015

Yes, I think it can just be hidden. This is unlikely to be called by anyone, and a quick search of github didn't turn up any obvious callers.

@SparkQA
Copy link

SparkQA commented Feb 3, 2015

Test build #26557 has finished for PR 4318 at commit 586ade6.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26557/
Test FAILed.

@mengxr
Copy link
Contributor Author

mengxr commented Feb 3, 2015

A Spark SQL test failed. Already pinged @liancheng to take a look. I'm going to merge this.

@asfgit asfgit closed this in ef65cf0 Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants