[SPARK-45458][SQL] Convert IllegalArgumentException to SparkIllegalArgumentException in bitwiseExpressions #43271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gumentException in bitwiseExpressions and add some UT
…gumentException in bitwiseExpressions and add some UT
…gumentException in bitwiseExpressions and add some UT
panbingkun
changed the title
…gumentException in bitwiseExpressions
cloud-fan
reviewed
Oct 9, 2023
| @@ -92,6 +92,11 @@ | |||
| ], | |||
| "sqlState" : "22003" | |||
| }, | |||
| "BIT_POSITION_OUT_OF_RANGE" : { | |||
There was a problem hiding this comment.
IIRC we have an error class for invalid function arguments, shall we reuse it?
There was a problem hiding this comment.
We have the error class INVALID_PARAMETER_VALUE, @panbingkun could you re-use or create a sub-class there, please.
There was a problem hiding this comment.
Okay, let me to do it.
MaxGekk
requested changes
Oct 9, 2023
| @@ -92,6 +92,11 @@ | |||
| ], | |||
| "sqlState" : "22003" | |||
| }, | |||
| "BIT_POSITION_OUT_OF_RANGE" : { | |||
There was a problem hiding this comment.
We have the error class INVALID_PARAMETER_VALUE, @panbingkun could you re-use or create a sub-class there, please.
…gumentException in bitwiseExpressions
MaxGekk
approved these changes
Oct 10, 2023
|
+1, LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to convert IllegalArgumentException to SparkIllegalArgumentException in bitwiseExpressions.
Why are the changes needed?
The changes improve the error framework.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.