Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQL] DataFrame API update #4332

Closed
wants to merge 2 commits into from
Closed

[SQL] DataFrame API update #4332

wants to merge 2 commits into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Feb 3, 2015

  1. Added Java-friendly version of the expression operators (i.e. gt, geq)
  2. Added JavaDoc for most operators
  3. Simplified expression operators by having only one version of the function (that accepts Any). Previously we had two methods for each expression operator, one accepting Any and another accepting Column.
  4. agg function now accepts varargs of (String, String).

@rxin
random commit.
576d07a 
Conflicts:
	sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala
@rxin
Added Java friendly expression methods.
ab0aa69 
Added JavaDoc.
For each expression operator, have only one version of the function (that accepts Any). Previously we had two methods for each expression operator, one accepting Any and another accepting Column.
@SparkQA
Copy link

SparkQA commented Feb 3, 2015

Test build #26644 has started for PR 4332 at commit ab0aa69.

  • This patch merges cleanly.

@rxin
Copy link
Contributor Author

rxin commented Feb 3, 2015

cc @davies Number 3 is a big change - but it does simplify the API documentation quite a bit.

davies
davies reviewed Feb 3, 2015
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/Dsl.scala
* df.select( negate(df.col("amount")) );
* }}}
*/
def negate(e: Column): Column = -e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

negative or neg?

@SparkQA
Copy link

SparkQA commented Feb 3, 2015

Test build #26644 has finished for PR 4332 at commit ab0aa69.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26644/
Test PASSed.

@asfgit asfgit closed this in 4204a12 Feb 3, 2015
@rxin rxin mentioned this pull request Feb 3, 2015
Closed
@rxin rxin deleted the df-update branch February 3, 2015 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rxin @SparkQA @AmplabJenkins @davies