[SPARK-45541][CORE] Add SSLFactory #43386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test failures looked unrelated, retrying now though. |
|
cc @mridulm @JoshRosen now that tests are green |
mridulm
reviewed
Oct 18, 2023
common/network-common/src/main/java/org/apache/spark/network/ssl/SSLFactory.java
Outdated
Show resolved
Hide resolved
common/network-common/src/main/java/org/apache/spark/network/ssl/SSLFactory.java
Outdated
Show resolved
Hide resolved
common/network-common/src/main/java/org/apache/spark/network/ssl/SSLFactory.java
Show resolved
Hide resolved
common/network-common/src/main/java/org/apache/spark/network/ssl/SSLFactory.java
Outdated
Show resolved
Hide resolved
common/network-common/src/main/java/org/apache/spark/network/ssl/SSLFactory.java
Outdated
Show resolved
Hide resolved
common/network-common/src/main/java/org/apache/spark/network/ssl/SSLFactory.java
Outdated
Show resolved
Hide resolved
common/network-common/src/main/java/org/apache/spark/network/ssl/SSLFactory.java
Outdated
Show resolved
Hide resolved
common/network-common/src/main/java/org/apache/spark/network/ssl/SSLFactory.java
Outdated
Show resolved
Hide resolved
common/network-common/src/main/java/org/apache/spark/network/ssl/SSLFactory.java
Outdated
Show resolved
Hide resolved
hasnain-db
force-pushed
the
spark-tls-factory
branch
from
ed97d4d
to
a1c0f41
Compare
hasnain-db
commented
Oct 19, 2023
common/network-common/src/main/java/org/apache/spark/network/ssl/SSLFactory.java
Show resolved
Hide resolved
mridulm
reviewed
Oct 20, 2023
common/network-common/src/main/java/org/apache/spark/network/ssl/SSLFactory.java
Outdated
Show resolved
Hide resolved
hasnain-db
force-pushed
the
spark-tls-factory
branch
from
f18731e
to
edf1a02
Compare
|
will re-request review once CI comes back |
mridulm
reviewed
Oct 21, 2023
common/network-common/src/main/java/org/apache/spark/network/ssl/SSLFactory.java
Outdated
Show resolved
Hide resolved
mridulm
approved these changes
Oct 22, 2023
|
thanks! some jobs failed, rerunning them so hopefully there is a green CI in the morning |
|
The test failure is unrelated to this PR. Thanks for fixing this @hasnain-db ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As titled - add a factory which supports creating SSL engines, and a corresponding builder for it. This will be used in a follow up PR by the
TransportContextand related files to add SSL support.Why are the changes needed?
We need a mechanism to initialize the appropriate SSL implementation with the configured settings (such as protocol, ciphers, etc) for RPC SSL support.
Does this PR introduce any user-facing change?
No
How was this patch tested?
existing tests. This will be more thoroughly tested in a follow up PR which adds callsites to it. It has been integration tested as part of #42685
Was this patch authored or co-authored using generative AI tooling?
No