[SPARK-45569][SQL] Assign name to the error _LEGACY_ERROR_TEMP_2152 #43396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beliefer
reviewed
Oct 17, 2023
| @@ -191,7 +191,7 @@ object ExpressionEncoder { | |||
| * thread-safe. Note that multiple calls to `apply(..)` return the same actual [[InternalRow]] | |||
| * object. Thus, the caller should copy the result before making another call if required. | |||
| */ | |||
| class Serializer[T](private val expressions: Seq[Expression]) | |||
There was a problem hiding this comment.
Please avoid this change.
You can use ExpressionEncoder.createDeserializer
There was a problem hiding this comment.
Thank you for reminding this @beliefer , it was modified by accident and I have reverted it, PTAL again.
dengziming
force-pushed
the
SPARK-45569
branch
from
c79f9be
to
c82678b
Compare
beliefer
reviewed
Oct 18, 2023
| @@ -652,7 +652,7 @@ class ExpressionEncoderSuite extends CodegenInterpretedPlanTest with AnalysisTes | |||
| val e = intercept[RuntimeException] { | |||
| toRow(bigNumeric) | |||
| } | |||
| assert(e.getMessage.contains("Error while encoding")) | |||
| assert(e.getMessage.contains("Failed to encode a value of the expressions:")) | |||
There was a problem hiding this comment.
Maybe this is a chance to use checkError with errorClass. cc @MaxGekk
There was a problem hiding this comment.
Yep, if it is possible let's use checkError but this one is from a nested non-Spark exception, isn't.
| @@ -276,8 +276,8 @@ class RowEncoderSuite extends CodegenInterpretedPlanTest { | |||
| val schema = new StructType().add("int", IntegerType) | |||
| val encoder = ExpressionEncoder(schema) | |||
| val e = intercept[RuntimeException](toRow(encoder, null)) | |||
| assert(e.getMessage.contains("Null value appeared in non-nullable field")) | |||
| assert(e.getMessage.contains("top level Product or row object")) | |||
| assert(e.getCause.getMessage.contains("Null value appeared in non-nullable field")) | |||
|
@dengziming Please, resolve conflicts. |
dengziming
force-pushed
the
SPARK-45569
branch
from
0771238
to
4afd3ad
Compare
|
All GAs passed: https://github.com/dengziming/spark/actions/runs/6570868445/job/17859440831 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Assign the name
EXPRESSION_ENCODING_FAILEDto the legacy error class_LEGACY_ERROR_TEMP_2152.Why are the changes needed?
To assign proper name as a part of activity in SPARK-37935.
Does this PR introduce any user-facing change?
Yes, the error message will include the error class name
How was this patch tested?
Add a unit test to produce the error from user code.
Was this patch authored or co-authored using generative AI tooling?
No.