[SPARK-45573][SQL] Assign name to the error _LEGACY_ERROR_TEMP_2153 #43414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
requested changes
Oct 18, 2023
| @@ -3015,6 +3015,12 @@ | |||
| ], | |||
| "sqlState" : "4274K" | |||
| }, | |||
| "UNEXPECTED_SERIALIZER_FOR_CLASS" : { | |||
| "message" : [ | |||
| "Class <clsName> has unexpected serializer: <objSerializer>." | |||
There was a problem hiding this comment.
Suggested change
| "Class <clsName> has unexpected serializer: <objSerializer>." | |
| "The class <className> has an unexpected expression serializer. Expects \"STRUCT\" or \"IF\" which returns \"STRUCT\" but found <expr>." |
MaxGekk
reviewed
Oct 18, 2023
| @@ -1362,7 +1362,7 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase with ExecutionE | |||
| def classHasUnexpectedSerializerError( | |||
| clsName: String, objSerializer: Expression): SparkRuntimeException = { | |||
| new SparkRuntimeException( | |||
| errorClass = "_LEGACY_ERROR_TEMP_2153", | |||
| errorClass = "UNEXPECTED_SERIALIZER_FOR_CLASS", | |||
| messageParameters = Map( | |||
| "clsName" -> clsName, | |||
| "objSerializer" -> objSerializer.toString())) | |||
There was a problem hiding this comment.
Could you quote the expression by toSQLExpr
|
Thank you @MaxGekk for your review, the CI attempt-2 seems fine and some failures of attempt-1 is unrelated. |
|
+1, LGTM. Merging to master. |
|
@dengziming Please, correct the JIRA to vhttps://issues.apache.org/jira/browse/SPARK-45573 |
dengziming
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Assign the name
UNEXPECTED_SERIALIZER_FOR_CLASSto the legacy error class_LEGACY_ERROR_TEMP_2153.Why are the changes needed?
To assign proper name as a part of activity in SPARK-37935.
Does this PR introduce any user-facing change?
Yes, the error message will include the error class name
How was this patch tested?
Add a unit test to produce the error from user code.
Was this patch authored or co-authored using generative AI tooling?
No.