Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-5574] use given name prefix in dir #4344

Closed
wants to merge 1 commit into from

Conversation

squito
Copy link
Contributor

@squito squito commented Feb 3, 2015

https://issues.apache.org/jira/browse/SPARK-5574

very minor, doesn't effect external behavior at all.
Note that after this change, some of these dirs no longer will have "spark" in the name at all. I could change those locations that do pass in a name prefix to also include "spark", eg. "blockmgr" -> "spark-blockmgr"

@SparkQA
Copy link

SparkQA commented Feb 3, 2015

Test build #26681 has started for PR 4344 at commit 33a84fe.

  • This patch merges cleanly.

@vanzin
Copy link
Contributor

vanzin commented Feb 3, 2015

hey @squito , could you add [SPARK-5574] to the PR title to follow the usual convention? Thx!

@vanzin
Copy link
Contributor

vanzin commented Feb 3, 2015

other than that, LGTM.

@squito squito changed the title use given name prefix in dir [SPARK-5574] use given name prefix in dir Feb 3, 2015
@squito
Copy link
Contributor Author

squito commented Feb 3, 2015

whoops, sorry I forgot about the title, just updated.

@SparkQA
Copy link

SparkQA commented Feb 3, 2015

Test build #26681 has finished for PR 4344 at commit 33a84fe.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class SimpleFunctionRegistry(val caseSensitive: Boolean) extends FunctionRegistry
    • class StringKeyHashMap[T](normalizer: (String) => String)
    • case class MultiAlias(child: Expression, names: Seq[String])

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26681/
Test FAILed.

@rxin
Copy link
Contributor

rxin commented Feb 4, 2015

Do you know what the common root is? Is it just tmp? If yes, maybe we do want to prefix spark always. If it is some special Spark tmp folder, then I think it is fine to not have the spark prefix.

@vanzin
Copy link
Contributor

vanzin commented Feb 4, 2015

commit 52f575 added a user-specific root under the temp dir, so you'd always have these directories under one that's named spark-[uuid].

@rxin
Copy link
Contributor

rxin commented Feb 4, 2015

Then this lgtm.

@pwendell
Copy link
Contributor

pwendell commented Feb 4, 2015

LGTM too

@pwendell
Copy link
Contributor

pwendell commented Feb 4, 2015

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Feb 4, 2015

Test build #26728 has started for PR 4344 at commit 33a84fe.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 4, 2015

Test build #26728 has finished for PR 4344 at commit 33a84fe.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26728/
Test PASSed.

@rxin
Copy link
Contributor

rxin commented Feb 4, 2015

Merging this in master & branch-1.3.

asfgit pushed a commit that referenced this pull request Feb 4, 2015
https://issues.apache.org/jira/browse/SPARK-5574

very minor, doesn't effect external behavior at all.
Note that after this change, some of these dirs no longer will have "spark" in the name at all.  I could change those locations that do pass in a name prefix to also include "spark", eg. "blockmgr" -> "spark-blockmgr"

Author: Imran Rashid <irashid@cloudera.com>

Closes #4344 from squito/SPARK-5574 and squashes the following commits:

33a84fe [Imran Rashid] use given name prefix in dir

(cherry picked from commit 5aa0f21)
Signed-off-by: Reynold Xin <rxin@databricks.com>
@asfgit asfgit closed this in 5aa0f21 Feb 4, 2015
@squito squito deleted the SPARK-5574 branch June 10, 2015 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants