-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-5574] use given name prefix in dir #4344
Conversation
Test build #26681 has started for PR 4344 at commit
|
hey @squito , could you add |
other than that, LGTM. |
whoops, sorry I forgot about the title, just updated. |
Test build #26681 has finished for PR 4344 at commit
|
Test FAILed. |
Do you know what the common root is? Is it just tmp? If yes, maybe we do want to prefix spark always. If it is some special Spark tmp folder, then I think it is fine to not have the spark prefix. |
commit 52f575 added a user-specific root under the temp dir, so you'd always have these directories under one that's named |
Then this lgtm. |
LGTM too |
Jenkins, test this please. |
Test build #26728 has started for PR 4344 at commit
|
Test build #26728 has finished for PR 4344 at commit
|
Test PASSed. |
Merging this in master & branch-1.3. |
https://issues.apache.org/jira/browse/SPARK-5574 very minor, doesn't effect external behavior at all. Note that after this change, some of these dirs no longer will have "spark" in the name at all. I could change those locations that do pass in a name prefix to also include "spark", eg. "blockmgr" -> "spark-blockmgr" Author: Imran Rashid <irashid@cloudera.com> Closes #4344 from squito/SPARK-5574 and squashes the following commits: 33a84fe [Imran Rashid] use given name prefix in dir (cherry picked from commit 5aa0f21) Signed-off-by: Reynold Xin <rxin@databricks.com>
https://issues.apache.org/jira/browse/SPARK-5574
very minor, doesn't effect external behavior at all.
Note that after this change, some of these dirs no longer will have "spark" in the name at all. I could change those locations that do pass in a name prefix to also include "spark", eg. "blockmgr" -> "spark-blockmgr"