Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-45523][PYTHON] Refactor the null-checking to have shortcuts #43492

Closed
wants to merge 1 commit into from

Conversation

ueshin
Copy link
Member

@ueshin ueshin commented Oct 24, 2023

What changes were proposed in this pull request?

This is a follow-up of #43356.

Refactor the null-checking to have shortcuts.

Why are the changes needed?

The null-check can have shortcuts for some cases.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

The existing tests.

Was this patch authored or co-authored using generative AI tooling?

No.

@ueshin
Copy link
Member Author

ueshin commented Oct 24, 2023

cc @dtenedor

Copy link
Contributor

@dtenedor dtenedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor!

@ueshin
Copy link
Member Author

ueshin commented Oct 24, 2023

The failed tests seem not related to this PR. Let me merge this now.

@ueshin
Copy link
Member Author

ueshin commented Oct 24, 2023

Thanks. merging to master.

@ueshin ueshin closed this in 68c0f64 Oct 24, 2023
@ueshin ueshin changed the title [SPARK-45523][Python] Refactor the null-checking to have shortcuts [SPARK-45523][PYTHON] Refactor the null-checking to have shortcuts Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants