[SPARK-45641][UI] Display the application start time on AllJobsPage #43495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the Total Uptime segment on AllJobsPage
yaooqinn
changed the title
There was a problem hiding this comment.
Thank you, @yaooqinn .
It sounds good, but can we have this as a separate line? WDYT?
yaooqinn
changed the title
|
@dongjoon-hyun Your suggestion SGTM. Addressed. Please retake a look when you have some time. Thank you. |
dongjoon-hyun
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
+1, LGTM. Thank you for updating, @yaooqinn . It looks nice.
|
I also verified this UI patch locally. Merged to master for Apache Spark 4.0. |
|
Thank you very much, @dongjoon-hyun for the merge and effort of extra local verification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds content for the application start time on AllJobsPage.
Why are the changes needed?
The application start time currently remains in a long value form, which is not convenient for users to read on the environment tab. It's also useful on the AllJobsPage, such as identifying a long pause before job 0 gets scheduled.
Does this PR introduce any user-facing change?
yes, UI updates
How was this patch tested?
locally tested
Was this patch authored or co-authored using generative AI tooling?
no