Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-5582] [history] Ignore empty log directories. #4352

Closed
wants to merge 1 commit into from
Closed

[SPARK-5582] [history] Ignore empty log directories. #4352

wants to merge 1 commit into from

Conversation

vanzin
Copy link
Contributor

@vanzin vanzin commented Feb 4, 2015

Empty log directories are not useful at the moment, but if one ends
up showing in the log root, it breaks the code that checks for log
directories.

[SPARK-5582] Fix exception when looking at empty directories.
1a6a3d4 
Empty log directories are not useful at the moment, but if one ends
up showing in the log root, it breaks the code that checks for log
directories.
@vanzin
Copy link
Contributor Author

vanzin commented Feb 4, 2015

Note: getModificationTime returning Option[Long] is not super pretty, but it avoids a second call to fs.listStatus to get rid of empty directories, thus avoiding another round-trip to the NN.

@SparkQA
Copy link

SparkQA commented Feb 4, 2015

Test build #26711 has started for PR 4352 at commit 1a6a3d4.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 4, 2015

Test build #26711 has finished for PR 4352 at commit 1a6a3d4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26711/
Test PASSed.

@srowen
Copy link
Member

srowen commented Feb 6, 2015

LGTM since it strictly changes a case which would result in an exception into the proper no-op, and has a test to demonstrate the behavior.

@asfgit asfgit closed this in 8569289 Feb 6, 2015
@JoshRosen
Copy link
Contributor

I've also merged this into branch-1.3 (1.3.0).

asfgit pushed a commit that referenced this pull request Feb 6, 2015
@JoshRosen
[SPARK-5582] [history] Ignore empty log directories.
faccdcb 
Empty log directories are not useful at the moment, but if one ends
up showing in the log root, it breaks the code that checks for log
directories.

Author: Marcelo Vanzin <vanzin@cloudera.com>

Closes #4352 from vanzin/SPARK-5582 and squashes the following commits:

1a6a3d4 [Marcelo Vanzin] [SPARK-5582] Fix exception when looking at empty directories.
@vanzin vanzin deleted the SPARK-5582 branch February 12, 2015 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@vanzin @SparkQA @AmplabJenkins @srowen @JoshRosen